|
Name |
|
Date |
Size |
#Lines |
LOC |
| .. | | - | - |
| README | D | 23-Nov-2023 | 2.2 KiB | 63 | 40 |
| sha1.c | D | 23-Nov-2023 | 5.1 KiB | 175 | 113 |
| sha1.h | D | 23-Nov-2023 | 1.6 KiB | 54 | 36 |
README
1This local copy of a SHA1 implementation based on the sources below.
2
3Why:
4 - Some libraries suffer from race condition and other issues. For example see
5commit ade3108bb5b0 ("util: Fix race condition on libgcrypt initialization").
6
7 - Fold the handling and detection of _eight_ implementations at configure
8stage and _seven_ different codepaths.
9
10 - Have a single, uniform, code used by developers, testers and users.
11
12 - Avoid conflicts when using software which ships with it's own SHA1 library.
13The latter of which conflicting with the one mesa is build against.
14
15
16
17Source:
18The SHA1 implementation is copied verbatim from the following links.
19At the time of checkout HEAD is 1.25 and 1.24 respectively.
20
21http://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/src/lib/libc/hash/sha1.c?rev=HEAD
22http://cvsweb.openbsd.org/cgi-bin/cvsweb/~checkout~/src/include/sha1.h?rev=HEAD
23
24
25Notes:
26 - The files should not have any local changes. If there are any they should be
27clearly documented below and one should aim to upstream them where possible.
28
29 - Files will be periodically syncronised with the respective upstream sources.
30Updates will be made regularly, but since the code is _not_ aimed as a
31cryptography solution any issues found should not be considered security ones.
32
33
34Local changes:
35 - Removed __bounded__ attribute qualifiers. Unavailable on platforms targeted
36by Mesa. Upstream status: TBD (N/A ?)
37
38 - Pick the sha1.h header from the current folder, by using "" over <> in the
39include directive. Upstream status: TBD
40
41 - Remove unused function prototypes - SHA1End, SHA1File, SHA1FileChunk and
42SHA1Data. Upstream status: TBD
43
44 - Use stdint.h integer types - u_int{8,16,32}_t -> uint{8,16,32}_t and
45u_int -> uint32_t, change header include. Upstream status: TBD
46
47 - Revert sha1.c rev 1.26 change (introduce DEF_WEAK).
48Upstream status: TBD (N/A ?)
49
50 - Add stdint.h include in sha1.h for uint*_t types. Upstream status: TBD
51
52 - Add stddef.h include in sha1.h for size_t type. Upstream status: TBD
53
54 - Use memset over explicit_bzero, since memset_s once isn't widely available.
55Upstream status: TBD (N/A ?)
56
57 - Manually expand __BEGIN_DECLS/__END_DECLS and make sure that they include
58the struct declaration.
59Upstream status: TBD
60
61 - Add non-typedef struct name.
62Upstream status: TBD
63