1<?xml version="1.0" encoding="UTF-8"?> 2<issues format="6" by="lint 8.4.0-alpha08" type="baseline" client="" dependencies="true" name="" variant="all" version="8.4.0-alpha08"> 3 4 <issue 5 id="DefaultLocale" 6 message="Implicitly using the default locale is a common source of bugs: Use `String.format(Locale, ...)` instead" 7 errorLine1=" return String.format(" 8 errorLine2=" ^"> 9 <location 10 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/stats/FledgeApiCallStatsMatcher.java" 11 line="49" 12 column="16"/> 13 </issue> 14 15 <issue 16 id="DefaultLocale" 17 message="Implicitly using the default locale is a common source of bugs: Use `String.format(Locale, ...)` instead" 18 errorLine1=" String jsonString = String.format("{\"flip_probability\": %f}", mockFlipProbability);" 19 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> 20 <location 21 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/measurement/SourceFixture.java" 22 line="236" 23 column="29"/> 24 </issue> 25 26 <issue 27 id="NewApi" 28 message="Call requires API level 34 (current min is 33): `java.lang.String#formatted`" 29 errorLine1=" AdTechIdentifier buyer = AdTechIdentifier.fromString("buyer%d.com".formatted(b));" 30 errorLine2=" ~~~~~~~~~"> 31 <location 32 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/android/adservices/customaudience/CustomAudienceFixture.java" 33 line="177" 34 column="80"/> 35 </issue> 36 37 <issue 38 id="NewApi" 39 message="Call requires API level 34 (current min is 33): `java.lang.String#formatted`" 40 errorLine1=" .setName("testCustomAudience_%s".formatted(generateHash(b, c)))" 41 errorLine2=" ~~~~~~~~~"> 42 <location 43 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/android/adservices/customaudience/CustomAudienceFixture.java" 44 line="188" 45 column="66"/> 46 </issue> 47 48 <issue 49 id="VisibleForTests" 50 message="This method should only be accessed from tests or within private scope" 51 errorLine1=" APP10_PACKAGE_NAME + DATASTORE_KEY_SEPARATOR + APP10_UID;" 52 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> 53 <location 54 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/data/consent/AppConsentDaoFixture.java" 55 line="34" 56 column="34"/> 57 </issue> 58 59 <issue 60 id="VisibleForTests" 61 message="This method should only be accessed from tests or within private scope" 62 errorLine1=" APP20_PACKAGE_NAME + DATASTORE_KEY_SEPARATOR + APP20_UID;" 63 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> 64 <location 65 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/data/consent/AppConsentDaoFixture.java" 66 line="36" 67 column="34"/> 68 </issue> 69 70 <issue 71 id="VisibleForTests" 72 message="This method should only be accessed from tests or within private scope" 73 errorLine1=" APP30_PACKAGE_NAME + DATASTORE_KEY_SEPARATOR + APP30_UID;" 74 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~"> 75 <location 76 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/data/consent/AppConsentDaoFixture.java" 77 line="38" 78 column="34"/> 79 </issue> 80 81 <issue 82 id="VisibleForTests" 83 message="This class should only be accessed from tests or within private scope" 84 errorLine1=" public static CustomAudienceUpdatableData.Builder getValidBuilderFullSuccessfulResponse()" 85 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> 86 <location 87 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 88 line="342" 89 column="19"/> 90 </issue> 91 92 <issue 93 id="VisibleForTests" 94 message="This method should only be accessed from tests or within private scope" 95 errorLine1=" return CustomAudienceUpdatableData.builder()" 96 errorLine2=" ~~~~~~~"> 97 <location 98 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 99 line="344" 100 column="44"/> 101 </issue> 102 103 <issue 104 id="VisibleForTests" 105 message="This method should only be accessed from tests or within private scope" 106 errorLine1=" .setUserBiddingSignals(" 107 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> 108 <location 109 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 110 line="345" 111 column="18"/> 112 </issue> 113 114 <issue 115 id="VisibleForTests" 116 message="This method should only be accessed from tests or within private scope" 117 errorLine1=" .setTrustedBiddingData(" 118 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> 119 <location 120 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 121 line="350" 122 column="18"/> 123 </issue> 124 125 <issue 126 id="VisibleForTests" 127 message="This method should only be accessed from tests or within private scope" 128 errorLine1=" .setAds(DBAdDataFixture.getValidDbAdDataListByBuyer(CommonFixture.VALID_BUYER_1))" 129 errorLine2=" ~~~~~~"> 130 <location 131 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 132 line="354" 133 column="18"/> 134 </issue> 135 136 <issue 137 id="VisibleForTests" 138 message="This method should only be accessed from tests or within private scope" 139 errorLine1=" .setAttemptedUpdateTime(CommonFixture.FIXED_NOW)" 140 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> 141 <location 142 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 143 line="355" 144 column="18"/> 145 </issue> 146 147 <issue 148 id="VisibleForTests" 149 message="This method should only be accessed from tests or within private scope" 150 errorLine1=" .setInitialUpdateResult(BackgroundFetchRunner.UpdateResultType.SUCCESS)" 151 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> 152 <location 153 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 154 line="356" 155 column="18"/> 156 </issue> 157 158 <issue 159 id="VisibleForTests" 160 message="This method should only be accessed from tests or within private scope" 161 errorLine1=" .setContainsSuccessfulUpdate(true);" 162 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~"> 163 <location 164 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 165 line="357" 166 column="18"/> 167 </issue> 168 169 <issue 170 id="VisibleForTests" 171 message="This class should only be accessed from tests or within private scope" 172 errorLine1=" public static CustomAudienceUpdatableData.Builder getValidBuilderEmptySuccessfulResponse() {" 173 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> 174 <location 175 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 176 line="360" 177 column="19"/> 178 </issue> 179 180 <issue 181 id="VisibleForTests" 182 message="This method should only be accessed from tests or within private scope" 183 errorLine1=" return CustomAudienceUpdatableData.builder()" 184 errorLine2=" ~~~~~~~"> 185 <location 186 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 187 line="361" 188 column="44"/> 189 </issue> 190 191 <issue 192 id="VisibleForTests" 193 message="This method should only be accessed from tests or within private scope" 194 errorLine1=" .setUserBiddingSignals(null)" 195 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> 196 <location 197 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 198 line="362" 199 column="18"/> 200 </issue> 201 202 <issue 203 id="VisibleForTests" 204 message="This method should only be accessed from tests or within private scope" 205 errorLine1=" .setTrustedBiddingData(null)" 206 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> 207 <location 208 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 209 line="363" 210 column="18"/> 211 </issue> 212 213 <issue 214 id="VisibleForTests" 215 message="This method should only be accessed from tests or within private scope" 216 errorLine1=" .setAds(null)" 217 errorLine2=" ~~~~~~"> 218 <location 219 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 220 line="364" 221 column="18"/> 222 </issue> 223 224 <issue 225 id="VisibleForTests" 226 message="This method should only be accessed from tests or within private scope" 227 errorLine1=" .setAttemptedUpdateTime(CommonFixture.FIXED_NOW)" 228 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> 229 <location 230 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 231 line="365" 232 column="18"/> 233 </issue> 234 235 <issue 236 id="VisibleForTests" 237 message="This method should only be accessed from tests or within private scope" 238 errorLine1=" .setInitialUpdateResult(BackgroundFetchRunner.UpdateResultType.SUCCESS)" 239 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> 240 <location 241 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 242 line="366" 243 column="18"/> 244 </issue> 245 246 <issue 247 id="VisibleForTests" 248 message="This method should only be accessed from tests or within private scope" 249 errorLine1=" .setContainsSuccessfulUpdate(true);" 250 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~"> 251 <location 252 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 253 line="367" 254 column="18"/> 255 </issue> 256 257 <issue 258 id="VisibleForTests" 259 message="This class should only be accessed from tests or within private scope" 260 errorLine1=" public static CustomAudienceUpdatableData.Builder getValidBuilderEmptyFailedResponse() {" 261 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> 262 <location 263 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 264 line="370" 265 column="19"/> 266 </issue> 267 268 <issue 269 id="VisibleForTests" 270 message="This method should only be accessed from tests or within private scope" 271 errorLine1=" return CustomAudienceUpdatableData.builder()" 272 errorLine2=" ~~~~~~~"> 273 <location 274 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 275 line="371" 276 column="44"/> 277 </issue> 278 279 <issue 280 id="VisibleForTests" 281 message="This method should only be accessed from tests or within private scope" 282 errorLine1=" .setUserBiddingSignals(null)" 283 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> 284 <location 285 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 286 line="372" 287 column="18"/> 288 </issue> 289 290 <issue 291 id="VisibleForTests" 292 message="This method should only be accessed from tests or within private scope" 293 errorLine1=" .setTrustedBiddingData(null)" 294 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~"> 295 <location 296 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 297 line="373" 298 column="18"/> 299 </issue> 300 301 <issue 302 id="VisibleForTests" 303 message="This method should only be accessed from tests or within private scope" 304 errorLine1=" .setAds(null)" 305 errorLine2=" ~~~~~~"> 306 <location 307 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 308 line="374" 309 column="18"/> 310 </issue> 311 312 <issue 313 id="VisibleForTests" 314 message="This method should only be accessed from tests or within private scope" 315 errorLine1=" .setAttemptedUpdateTime(CommonFixture.FIXED_NOW)" 316 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> 317 <location 318 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 319 line="375" 320 column="18"/> 321 </issue> 322 323 <issue 324 id="VisibleForTests" 325 message="This method should only be accessed from tests or within private scope" 326 errorLine1=" .setInitialUpdateResult(BackgroundFetchRunner.UpdateResultType.SUCCESS)" 327 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~"> 328 <location 329 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 330 line="376" 331 column="18"/> 332 </issue> 333 334 <issue 335 id="VisibleForTests" 336 message="This method should only be accessed from tests or within private scope" 337 errorLine1=" .setContainsSuccessfulUpdate(false);" 338 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~"> 339 <location 340 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/service/customaudience/CustomAudienceUpdatableDataFixture.java" 341 line="377" 342 column="18"/> 343 </issue> 344 345 <issue 346 id="VisibleForTests" 347 message="This method should only be accessed from tests or within private scope" 348 errorLine1=" .computeNextEligibleUpdateTimeAfterSuccessfulUpdate(" 349 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> 350 <location 351 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/customaudience/DBCustomAudienceBackgroundFetchDataFixture.java" 352 line="39" 353 column="34"/> 354 </issue> 355 356 <issue 357 id="VisibleForTests" 358 message="This method should only be accessed from tests or within private scope" 359 errorLine1=" client.createObliviousHttpRequest(" 360 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> 361 <location 362 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/android/adservices/adselection/ObliviousHttpEncryptorWithSeedImpl.java" 363 line="111" 364 column="28"/> 365 </issue> 366 367 <issue 368 id="VisibleForTests" 369 message="This method should only be accessed from tests or within private scope" 370 errorLine1=" .isConfigurableHeapSizeSupported()" 371 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~"> 372 <location 373 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/common/WebViewSupportUtil.java" 374 line="60" 375 column="26"/> 376 </issue> 377 378 <issue 379 id="VisibleForTests" 380 message="This method should only be accessed from tests or within private scope" 381 errorLine1=" .isConsoleCallbackSupported()" 382 errorLine2=" ~~~~~~~~~~~~~~~~~~~~~~~~~~"> 383 <location 384 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/com/android/adservices/common/WebViewSupportUtil.java" 385 line="71" 386 column="26"/> 387 </issue> 388 389 <issue 390 id="SupportAnnotationUsage" 391 message="Top level class can't have private or protected access level" 392 errorLine1="@VisibleForTesting" 393 errorLine2="~~~~~~~~~~~~~~~~~~"> 394 <location 395 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/android/adservices/common/CallingAppUidSupplierFailureImpl.java" 396 line="27" 397 column="1"/> 398 </issue> 399 400 <issue 401 id="SupportAnnotationUsage" 402 message="Top level class can't have private or protected access level" 403 errorLine1="@VisibleForTesting" 404 errorLine2="~~~~~~~~~~~~~~~~~~"> 405 <location 406 file="packages/modules/AdServices/adservices/tests/unittest/fixtures/java/android/adservices/common/CallingAppUidSupplierProcessImpl.java" 407 line="26" 408 column="1"/> 409 </issue> 410 411</issues> 412